Fix module logo not displaying on configuration page - #95
Merged
Conversation
The configuration info block referenced the logo with a relative path
(../modules/ps_wirepayment/logo.png), which resolved correctly under the
legacy AdminModules URL but breaks under the PrestaShop Symfony module
manager route (/admin-dev/improve/modules/manage/action/...), where it
points to a non-existent admin URL and 404s.
Use the absolute {$module_dir} path assigned by Module::display() so the
logo resolves to /modules/ps_wirepayment/logo.png regardless of the
back office URL.
|
Hello @boo-code! This is your first pull request on ps_wirepayment repository of the PrestaShop project. Thank you, and welcome to this Open Source community! |
Codencode
approved these changes
Jul 27, 2026
ps-jarvis
added
the
Waiting for QA
Codencode
added
the
Waiting for QA by Community
Member
|
I tested the PR and it works correctly, so for me it's QA ✔️ 
@PrestaShop/committers |
Codencode
added
QA ✔️ by Community
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
../modules/ps_wirepayment/logo.png). That resolved correctly under the legacyAdminModulesURL, but the PrestaShop module manager is now a Symfony route (/admin-dev/improve/modules/manage/action/...), so the relative path resolves to a non-existent admin URL and the logo fails to load. Switched to the absolute{$module_dir}path thatModule::display()already assigns, so the logo resolves to/modules/ps_wirepayment/logo.pngregardless of the back office URL. This is the same pattern already used by other bundled modules (e.g.ps_googleanalytics)..../manage/action/modules/ps_wirepayment/logo.png404s). After: the logo displays, served from/modules/ps_wirepayment/logo.png(HTTP 200).