Skip to content

Gracefully handle exceptions in recovered cross reference sources #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PrinsFrank merged 1 commit into from
Jun 15, 2026
Merged

Gracefully handle exceptions in recovered cross reference sources #416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Document/CrossReference/Source/CrossReferenceSource.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
use PrinsFrank\PdfParser\Document\Dictionary\DictionaryValue\Reference\ReferenceValue;
use PrinsFrank\PdfParser\Document\Document;
use PrinsFrank\PdfParser\Exception\ParseFailureException;
use PrinsFrank\PdfParser\Exception\RuntimeException;
use PrinsFrank\PdfParser\Stream\Stream;

/** Can be both from a crossReferenceTable or a crossReferenceStream */
Expand All @@ -28,6 +29,7 @@ public function __construct(
$this->crossReferenceSections = $crossReferenceSections;
}

/** @throws RuntimeException */
public function getCrossReferenceEntry(int $objNumber, Document $document): CrossReferenceEntryInUseObject|CrossReferenceEntryCompressed|null {
foreach ($this->crossReferenceSections as $crossReferenceSection) {
$crossReferenceEntry = $crossReferenceSection->getCrossReferenceEntry($objNumber);
Expand Down
8 changes: 7 additions & 1 deletion src/Document/CrossReference/Source/RecoveredCrossReferenceSource.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
use PrinsFrank\PdfParser\Document\CrossReference\Source\Section\SubSection\Entry\CrossReferenceEntryCompressed;
use PrinsFrank\PdfParser\Document\CrossReference\Source\Section\SubSection\Entry\CrossReferenceEntryInUseObject;
use PrinsFrank\PdfParser\Document\Document;
use Throwable;

class RecoveredCrossReferenceSource extends CrossReferenceSource {
/**
Expand All @@ -23,7 +24,12 @@ public function __construct(

#[Override]
public function getCrossReferenceEntry(int $objNumber, Document $document): CrossReferenceEntryInUseObject|CrossReferenceEntryCompressed|null {
$crossReferenceEntry = parent::getCrossReferenceEntry($objNumber, $document);
try {
$crossReferenceEntry = parent::getCrossReferenceEntry($objNumber, $document);
} catch (Throwable) {
$crossReferenceEntry = null;
}

if ($crossReferenceEntry instanceof CrossReferenceEntryInUseObject
&& $document->stream->read($crossReferenceEntry->byteOffsetInDecodedStream, strlen($expectedStartObjMarker = sprintf('%d %d obj', $objNumber, $crossReferenceEntry->generationNumber))) === $expectedStartObjMarker) {
return $crossReferenceEntry;
Expand Down
2 changes: 2 additions & 0 deletions src/Document/CrossReference/Source/Section/CrossReferenceSection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
use PrinsFrank\PdfParser\Document\CrossReference\Source\Section\SubSection\Entry\CrossReferenceEntryCompressed;
use PrinsFrank\PdfParser\Document\CrossReference\Source\Section\SubSection\Entry\CrossReferenceEntryInUseObject;
use PrinsFrank\PdfParser\Document\Dictionary\Dictionary;
use PrinsFrank\PdfParser\Exception\RuntimeException;
use PrinsFrank\PdfParser\Stream\Stream;

/** There are multiple crossReference sections if there are incremental updates. See 7.5.6 */
Expand All @@ -21,6 +22,7 @@ public function __construct(
$this->crossReferenceSubSections = $crossReferenceSubSections;
}

/** @throws RuntimeException */
public function getCrossReferenceEntry(int $objNumber): CrossReferenceEntryInUseObject|CrossReferenceEntryCompressed|null {
foreach ($this->crossReferenceSubSections as $crossReferenceSubSection) {
if ($crossReferenceSubSection->containsObject($objNumber)) {
Expand Down
Loading