Pin test suite timezone to UTC so date tests are host-independent#420
Merged
Conversation
Dates parsed from PDFs without an explicit UTC offset fall back to the default timezone, so DateValueTest and the issue-150 sample only passed when the host ran in UTC (CI) and failed on other timezones. Pin date.timezone to UTC in phpunit.xml.dist and make the affected DateValueTest expectations use an explicit UTC timezone.
Owner
|
Thank you!!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to run the test suit on my system a couple of tests failed. This is because PDFs without a timezone return their time in local time (which is Europe/Berlin in my case) but the fixtures were created with a fixed UTC time zone. This makes sure tests run in UTC always.