Fix NeoForge 1.21.9 (PrismLauncher#4190) #8
Conversation
|
Hi, NeoForge developer here. This is not a great fix for many reasons. Would some Prism devs mind coming over to our Discord server and discussing the best approach in the #loader-dev channel? |
You're right, this was just a quick buggy fix to get NeoForge to launch, and honestly I'm not the right person to be making wrappers. I'm willing to change stuff to make it work correctly and I'm also okay with someone else making another PR. |
would be great if such discussion doesn't disappear behind the walls of discord, there's quite a few launchers relying on ForgeWrapper |
Yes, it looks like #loader-dev is hidden on the NeoForge discord server from "muggles." I'm "just a user" but I'm also a server op with a keen interest in using MultiMC to deploy our private modpack for MC 1.21.9. Is there a way I can get readonly access to #loader-dev to keep tabs on the conversation? Or as @phit suggested, we have it on https://github.com/neoforged/NeoForge (if that's appropriate) for public eyeballs? |
|
It's not a hidden channel, make sure you have #channels-and-roles configured so you can see the channel. Discord loves having poor default channel selections lol. Source: I removed my opt-in roles and could still view the channel |
Thank you. I've been using Discord for a while, but some things still catch me by surprise. |
|
Hi, I will close this PR in favor of #9 |
5 participants
This PR fixes NeoForge for all 1.21.9 versions PrismLauncher#4190. It seems to be a bit buggy, but that could be on my part by the way I've tested the wrapper.