Skip to content

Conversation

@CarliPinell
Copy link
Contributor

@CarliPinell CarliPinell commented Jan 5, 2026

Solution

A new validation was added to prevent the Trait method from attempting to obtain a file ID that was deleted from the draft when the draft environment variable TASK_DRAFTS_ENABLED=false

How to Test

  1. Create a screen that includes a required upload document field and a submit button.
  2. Saved it and assign it to a task in a process.
  3. Create a case.
  4. Upload a file (do not submit the form)
  5. Navigate to another section in ProcessMaker.
  6. Return to the case open the task.

Related Tickets & Packages

ci:deploy

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

Note

Fixes draft handling in TaskResourceIncludes. When TASK_DRAFTS_ENABLED=false and a draft exists, the code now deletes the draft and explicitly returns ['draft' => null] to prevent the frontend from attempting to load files from a deleted draft.

  • Adjusts includeDraft() to return null for draft after deletion when drafts are disabled

Written by Cursor Bugbot for commit 5133c6a. This will update automatically on new commits. Configure here.

Copy link
Contributor

@eiresendez eiresendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved — change correctly returns a null draft when drafts are disabled, preventing the frontend from requesting deleted files.

@vladyrichter
Copy link

QA server K8S was successfully deployed https://ci-1ea1cb5c18.engk8s.processmaker.net

@processmaker-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@sanjacornelius sanjacornelius requested review from PaolaPellegrini and removed request for mcraeteisha and sanjacornelius January 6, 2026 16:58
@nolanpro nolanpro merged commit 5e0cb7c into develop Jan 9, 2026
15 of 21 checks passed
@nolanpro nolanpro deleted the bugfix/FOUR-28509 branch January 9, 2026 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants