Skip to content

Conversation

@mystique09
Copy link
Contributor

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

This should fix the first response of the config command to be ephemeral.

Fixes #267

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • DevOps / CI changes

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Manual testing

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@mystique09 mystique09 added the chore Maintenance work (e.g. dependency upgrades, refactoring, etc.) label Dec 5, 2024
@mystique09 mystique09 self-assigned this Dec 5, 2024
@mystique09 mystique09 requested a review from a team as a code owner December 5, 2024 04:46
@kylecdrck kylecdrck added this to the Version X.X.X (2024-12-01) milestone Dec 7, 2024
@kylecdrck kylecdrck merged commit 7868899 into main Dec 13, 2024
@kylecdrck kylecdrck deleted the fix/config-ephemeral branch December 13, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Maintenance work (e.g. dependency upgrades, refactoring, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Forum Showcase Admin command response is not ephemeral

3 participants