Skip to content

fix: update build configuration and improve memory management#189

Open
kasyoukin wants to merge 1 commit into
Project-HAMi:mainfrom
kasyoukin:main
Open

fix: update build configuration and improve memory management#189
kasyoukin wants to merge 1 commit into
Project-HAMi:mainfrom
kasyoukin:main

Conversation

@kasyoukin
Copy link
Copy Markdown

  • Changed build type from Debug to Release in build.sh for optimized builds.
  • Updated dlsym function to use __dlsym_hook_section for better symbol resolution.
  • Enhanced cuMemCreate function to ensure proper device context handling and out-of-memory checks.
  • Fixed variable name in get_used_gpu_utilization for correct NVML device handling and added logging for NVML errors.
  • Cleaned up conditional logic in init_utilization_watcher for clarity.

- Changed build type from Debug to Release in build.sh for optimized builds.
- Updated dlsym function to use __dlsym_hook_section for better symbol resolution.
- Enhanced cuMemCreate function to ensure proper device context handling and out-of-memory checks.
- Fixed variable name in get_used_gpu_utilization for correct NVML device handling and added logging for NVML errors.
- Cleaned up conditional logic in init_utilization_watcher for clarity.
@hami-robot
Copy link
Copy Markdown
Contributor

hami-robot Bot commented Apr 29, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kasyoukin
Once this PR has been reviewed and has the lgtm label, please assign archlitchi for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hami-robot
Copy link
Copy Markdown
Contributor

hami-robot Bot commented Apr 29, 2026

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

  • 8536747 fix: update build configuration and improve memory management
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hami-robot
Copy link
Copy Markdown
Contributor

hami-robot Bot commented Apr 29, 2026

Welcome @kasyoukin! It looks like this is your first PR to Project-HAMi/HAMi-core 🎉

@hami-robot hami-robot Bot added the size/S label Apr 29, 2026
@archlitchi
Copy link
Copy Markdown
Member

please sign-off your commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants