Skip to content

fix shrreg initialization failure handling#194

Merged
hami-robot[bot] merged 2 commits into
Project-HAMi:mainfrom
huazq:fix/try-create-shrreg-failure
Jun 3, 2026
Merged

fix shrreg initialization failure handling#194
hami-robot[bot] merged 2 commits into
Project-HAMi:mainfrom
huazq:fix/try-create-shrreg-failure

Conversation

@huazq
Copy link
Copy Markdown

@huazq huazq commented May 13, 2026

Summary

  • Stop try_create_shrreg from continuing after shared-region file setup failures.
  • Check mmap failures with MAP_FAILED and clean up partially initialized fd/mapping state before exiting.
  • Use syscall-appropriate signed return types for lseek and write checks.

Test Plan

  • make check-cuda-hook-consistency
  • make build
  • Temporary regression harness with invalid CUDA_DEVICE_MEMORY_SHARED_CACHE exits without SIGSEGV

@hami-robot hami-robot Bot requested review from archlitchi and chaunceyjiang May 13, 2026 00:50
@hami-robot hami-robot Bot added the size/S label May 13, 2026
@huazq huazq force-pushed the fix/try-create-shrreg-failure branch from 8ee247f to 13e1f86 Compare May 13, 2026 01:04
Signed-off-by: huazhiqiang <huazhiqiang@cetccloud.com>
@huazq huazq force-pushed the fix/try-create-shrreg-failure branch from 13e1f86 to ddcedf3 Compare May 18, 2026 02:57
Comment thread src/multiprocess/multiprocess_memory_limit.c Outdated
Signed-off-by: huazhiqiang <huazhiqiang@cetccloud.com>
@huazq huazq force-pushed the fix/try-create-shrreg-failure branch from a728c6c to 5264d4d Compare May 30, 2026 10:30
Copy link
Copy Markdown
Contributor

@DSFans2014 DSFans2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Copy Markdown
Member

@archlitchi archlitchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hami-robot
Copy link
Copy Markdown
Contributor

hami-robot Bot commented Jun 3, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: archlitchi, huazq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hami-robot hami-robot Bot added the approved label Jun 3, 2026
@hami-robot hami-robot Bot merged commit 4bbd97a into Project-HAMi:main Jun 3, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants