fix: prevent unsigned integer underflow in NVML memory info hook#201
Open
miaobyte wants to merge 1 commit into
Open
fix: prevent unsigned integer underflow in NVML memory info hook#201miaobyte wants to merge 1 commit into
miaobyte wants to merge 1 commit into
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: miaobyte The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
miaobyte
force-pushed
the
fix/nvml-memory-underflow
branch
from
34a7e14 to
4c26dce
Compare
miaobyte
force-pushed
the
fix/nvml-memory-underflow
branch
from
4c26dce to
58d0f3c
Compare
When usage > limit, (limit - usage) wraps around to a massive unsigned value (~18 EB). Clamp both free and used so that free + used = total always holds, preventing corrupted values in monitoring tools. Fixes Project-HAMi#200 Signed-off-by: peng.li24 <peng.li24@nio.com> Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
miaobyte
force-pushed
the
fix/nvml-memory-underflow
branch
from
58d0f3c to
668ecb8
Compare
miaobyte
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix unsigned integer underflow in
_nvmlDeviceGetMemoryInfo: when GPU memory usage exceeds the configured limit,(limit - usage)with unsignedsize_twraps to ~18 EB, breaking monitoring tools.Changes
src/nvml/hook.c: computeclamped = (usage > limit) ? limit : usage, then derive bothused = clampedandfree = limit - clamped. This guaranteesfree + used = totalalways holds andfreenever underflows.Fixes #200
🤖 Generated with Claude Code