-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Fix compute_shape_offset non-tuple indexing for PyTorch >=2.9 #8776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Harrisaint
wants to merge
6
commits into
Project-MONAI:dev
Choose a base branch
from
Harrisaint:fix-shape-offset-bug
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
4b0e533
Fix compute_shape_offset non-tuple indexing for PyTorch >=2.9
Harrisaint d18cfc2
Add regression test for compute_shape_offset #8775
Harrisaint 680211a
Add missing copyright license header
Harrisaint a480b01
Fix import sorting and formatting
Harrisaint 8309c22
Fix import sorting and add annotations future import
Harrisaint 17c0e23
Add missing docstrings to regression test
Harrisaint File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| # Copyright (c) MONAI Consortium | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| import unittest | ||
|
|
||
| import numpy as np | ||
| import torch | ||
|
|
||
| from monai.data.utils import compute_shape_offset | ||
|
|
||
|
|
||
| class TestComputeShapeOffsetRegression(unittest.TestCase): | ||
| """Regression tests for `compute_shape_offset` input-shape handling.""" | ||
|
|
||
| def test_pytorch_size_input(self): | ||
| """Validate `torch.Size` input produces expected shape and offset. | ||
|
|
||
| Returns: | ||
| None. | ||
|
|
||
| Raises: | ||
| AssertionError: If computed shape/offset are not as expected. | ||
| """ | ||
| # 1. Create a PyTorch Size object (which triggered the original bug) | ||
| spatial_shape = torch.Size([10, 10, 10]) | ||
| in_affine = np.eye(4) | ||
| out_affine = np.eye(4) | ||
|
|
||
| # 2. Feed it into the function | ||
| shape, offset = compute_shape_offset(spatial_shape, in_affine, out_affine) | ||
Harrisaint marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| # 3. Prove it successfully processed the shape by checking its length | ||
| self.assertEqual(len(shape), 3) | ||
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| unittest.main() | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.