Fix std::is_trivial deprecation and clang-tidy warnings #7291
+57
−38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #7245
PR #7248 missed two
std::is_trivialinstances that use the::valuesyntax (infingerprint.hppandedge_based_graph_factory.hpp).Also, combining multiple type traits with
&&triggers a false positive from clang-tidy'smisc-redundant-expressioncheck. This PR splits all combinedstatic_assertconditions into separate statements to fix the CI failure.Changes
std::is_trivialwithstd::is_trivially_default_constructible+std::is_trivially_copyablestatic_assertconditions to avoid clang-tidy warningTasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?