Conversation
Contributor
Author
|
Ach! I forgot to bump the version number @rpruim . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a problem which made
findZeros()not work in a{learnr}document deployed on a server like shinyapps.io which farms out the execution of chunks. (Not a problem for those using{learnr}via a desktop or rstudio.cloud or, presumably, any shiny server that doesn't farm out execution.)The revised package checks cleanly.
I'll rely on @rpruim to merge this pull request in the correct way. There isn't any huge urgency on my part, since I've installed the issue-781 branch using
install_github()and shinyapps.io will take it from there also.There may be other old
{mosaic}functions that will have the same problem with{learnr}on shinyapps.io. I haven't found them yet.