Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
lubux
reviewed
Jul 13, 2026
|
|
||
| // VerifySignature returns nil iff sig is a valid signature, made by this | ||
| // key, of the data hashed into signed. signed is mutated by this call. | ||
| func (psk *PersistentSymmetricKey) VerifySignature(signed hash.Hash, sig *Signature) (err error) { |
Member
There was a problem hiding this comment.
VerifyAuthenticationTag? Authenticate?
Collaborator
Author
There was a problem hiding this comment.
This is partially a copy of the PublicKey.VerifySignature() function, and matches its interface, so I would prefer to keep it the same, also since we're verifying a signature packet here.
| IsSymmetricallyEncrypted bool // true if a passphrase could have decrypted the message. | ||
| DecryptedWith Key // the private key used to decrypt the message, if any. | ||
| DecryptedWithAlgorithm packet.CipherFunction // Stores the algorithm used to decrypt the message, if any. | ||
| IsSigned bool // true if the message is signed. |
Member
There was a problem hiding this comment.
Maybe we should add an additional info field IsSymmetricallyAuthenticated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements draft-ietf-openpgp-persistent-symmetric-keys-03.
Only adds support in
openpgp/v2, as API changes are needed.