Added a catch to the def gitVersionProvider in build.gradle with default
#181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-2483]. Remove the fix for an edge case where incomplete physical server status might lead to incorrect server status. It works well with /loads where v1 logicals do a full status refresh but never updates status to online with v2 logicals.
…es/ephemera-deploy to v1.14.0
…aults the value to "0.0.0.0" so it does not crash on initial build. Note: If this is not in line with what the project team would want, I would suggest at least leaving the try/catch in place and failing gracefully with a a different error message that tells policy for where to assign the version during builds.
AlgirdasPundzius
force-pushed
the
master
branch
from
aaa3fc7 to
ca69096
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason:
When following instructions on Readme, my gradle sync would not complete (on a brand new run of source code downloaded from GitHub).
I traced it down to a bit of ambiguity in the instructions regarding how to setup project. The gitVersionProvider function was crashing due to it trying to parse an empty string when it expects four numerals separated by periods.
This fix would decrease the need for internal knowledge to contribute to this project.
What I did:
Added a catch to the
def gitVersionProviderin build.gradle which defaults the value to "0.0.0.0" so it does not crash on initial build.Additional notes:
Note: If this is not in line with what the project team would want, I would suggest at least leaving the try/catch in place and failing gracefully with a a different error message that tells policy for where to assign the version during builds. Thank you!