Skip to content

allow decimal comma for numeric with tolerance #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zeileis wants to merge 1 commit into
base: main
Choose a base branch
from
Open

allow decimal comma for numeric with tolerance #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# webexercises (development version)

* allow decimal comma (in addition to decimal point) for numeric `fitb()` with tolerance

# webexercises 1.1.0

* quarto support (`create_quarto_doc()` and `add_to_quarto()`)
Expand Down
1 change: 1 addition & 0 deletions docs/articles/webexercises.html
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions docs/extra.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ solveme_func = function(e) {

// match numeric answers within a specified tolerance
if(this.dataset.tol > 0){
my_answer = my_answer.replace(/,/g, '.'); //also allow decimal comma
var tol = JSON.parse(this.dataset.tol);
var matches = real_answers.map(x => Math.abs(x - my_answer) < tol)
if (matches.reduce((a, b) => a + b, 0) > 0) {
Expand Down
1 change: 1 addition & 0 deletions inst/reports/default/webex.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ solveme_func = function(e) {

// match numeric answers within a specified tolerance
if(this.dataset.tol > 0){
my_answer = my_answer.replace(/,/g, '.'); //also allow decimal comma
var tol = JSON.parse(this.dataset.tol);
var matches = real_answers.map(x => Math.abs(x - my_answer) < tol)
if (matches.reduce((a, b) => a + b, 0) > 0) {
Expand Down
1 change: 1 addition & 0 deletions inst/rmarkdown/templates/webexercises/skeleton/skeleton.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -707,6 +707,7 @@ <h2>Hidden solutions and hints</h2>

// match numeric answers within a specified tolerance
if(this.dataset.tol > 0){
my_answer = my_answer.replace(/,/g, '.'); //also allow decimal comma
var tol = JSON.parse(this.dataset.tol);
var matches = real_answers.map(x => Math.abs(x - my_answer) < tol)
if (matches.reduce((a, b) => a + b, 0) > 0) {
Expand Down