refactor(client): remove redundant clone of run_id in format macro#579
Open
VolodymyrBg wants to merge 1 commit intoPsycheFoundation:mainfrom
Open
refactor(client): remove redundant clone of run_id in format macro#579VolodymyrBg wants to merge 1 commit intoPsycheFoundation:mainfrom
run_id in format macro#579VolodymyrBg wants to merge 1 commit intoPsycheFoundation:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The format! macro in Rust works with references, so calling
.clone()onp.run_id(a String) was forcing an unnecessary heap allocation and memory copy right before formatting, only to immediately drop it.Removed the useless
.clone()call fromp.run_idwhen generating wandb_info in the centralized client (app.rs). This eliminates the redundant memory allocation and aligns the code with idiomatic Rust.