Skip to content

Fix the initialization in LSTMWrapper #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
enriquezaf wants to merge 1 commit into
base: 3.0
Choose a base branch
from
+3 −3
Open

Fix the initialization in LSTMWrapper #461

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pufferlib/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,16 +111,16 @@ def __init__(self, env, policy, input_size=128, hidden_size=128):
self.hidden_size = hidden_size
self.is_continuous = self.policy.is_continuous

for name, param in self.named_parameters():
self.lstm = nn.LSTM(input_size, hidden_size)

for name, param in self.lstm.named_parameters():
if 'layer_norm' in name:
continue
if "bias" in name:
nn.init.constant_(param, 0)
elif "weight" in name and param.ndim >= 2:
nn.init.orthogonal_(param, 1.0)

self.lstm = nn.LSTM(input_size, hidden_size)

self.cell = torch.nn.LSTMCell(input_size, hidden_size)
self.cell.weight_ih = self.lstm.weight_ih_l0
self.cell.weight_hh = self.lstm.weight_hh_l0
Expand Down