Conversation
Summary of ChangesHello @kherembourg, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a significant version upgrade for the Purchasely SDK across all supported platforms. It updates the core Flutter SDK, along with its iOS and Android native components, to version 5.7.0. This ensures the project leverages the latest features, bug fixes, and performance improvements provided by the updated SDK, maintaining compatibility and enhancing the overall stability of the integration. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly bumps the version to 5.7.0 across all relevant files. The changes are consistent and reflect the summary provided. I've added a few suggestions to improve the changelogs for better developer experience by making them more descriptive. I also found some code style inconsistencies regarding indentation in both the Swift and Kotlin plugin files, for which I've suggested fixes. Overall, this is a solid release preparation.
purchasely/android/src/main/kotlin/io/purchasely/purchasely_flutter/PurchaselyFlutterPlugin.kt
Outdated
Show resolved
Hide resolved
- Bump Flutter SDK version to 5.7.0 - Update iOS Purchasely SDK to 5.7.0 - Update Android Purchasely SDK to 5.7.0 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ndency - io.purchasely:core:5.7.0 requires minSdkVersion 23 (was 21/16) - Update minSdkVersion in all plugin and example build.gradle files - Bump example app native SDK deps to 5.7.0 - Add pubspec_overrides in CI for purchasely_google (depends on unpublished purchasely_flutter ^5.7.0) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Fix tab indentation to spaces in PurchaselyFlutterPlugin.kt - Fix tab indentation to spaces in SwiftPurchaselyFlutterPlugin.swift - Add descriptive changelog entries for all three packages Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Document publish.sh known issues (hardcoded changelog URL, tab indentation) - Add Step 1b for changelog content updates - Add Step 3b for Android minSdkVersion checks - Document example app build.gradle as a file to update - Update Files Reference and Quick Reference Checklist Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
6f68a52 to
76b2442
Compare
Summary
Files changed
purchasely/pubspec.yaml,purchasely_google/pubspec.yaml,purchasely_android_player/pubspec.yaml— version bumppurchasely/ios/purchasely_flutter.podspec— iOS SDK 5.7.0purchasely/android/build.gradle,purchasely_google/android/build.gradle,purchasely_android_player/android/build.gradle— Android SDK 5.7.0SwiftPurchaselyFlutterPlugin.swift,PurchaselyFlutterPlugin.kt— bridge version 5.7.0VERSIONS.md— new version rowCHANGELOG.mdfiles — 5.7.0 entryTest plan
flutter test— 261 tests passedflutter analyze lib/— no issuespod update— Purchasely 5.7.0 resolved