fix: resolve @isaacs/brace-expansion vulnerability (CVE-2026-25547)#218
fix: resolve @isaacs/brace-expansion vulnerability (CVE-2026-25547)#218kherembourg merged 1 commit intomainfrom
Conversation
Add npm override in expo test project to force @isaacs/brace-expansion to >=5.0.1, fixing Dependabot alert #536 for uncontrolled resource consumption. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Summary of ChangesHello @kherembourg, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the security posture of the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request correctly addresses the security vulnerability in @isaacs/brace-expansion (CVE-2026-25547) by implementing npm overrides to force version 5.0.1 or higher. It also includes a patch update for the @purchasely suite of packages to version 5.6.2. My feedback focuses on refining the override version range for improved project stability and ensuring the package-lock.json is fully synchronized with the new overrides configuration.
| "react": "19.1.0", | ||
| "react-native": "0.81.5", | ||
| "react-native-purchasely": "^5.6.1" | ||
| "react-native-purchasely": "^5.6.2" |
There was a problem hiding this comment.
The package-lock.json file appears to be out of sync with the changes in package.json. When using the overrides field in an npm project with lockfile version 3, the overrides configuration should also be reflected in the root package entry (the "" key under "packages") of the lockfile. Its absence suggests the lockfile was not fully regenerated using npm install. Please run npm install to ensure the lockfile is correctly updated and synchronized.
| "private": true | ||
| "private": true, | ||
| "overrides": { | ||
| "@isaacs/brace-expansion": ">=5.0.1" |
There was a problem hiding this comment.
Using a broad range like >=5.0.1 in the overrides field can lead to unexpected breaking changes if a new major version of @isaacs/brace-expansion is released in the future. It is generally safer to use a caret range like ^5.0.1 to ensure you receive security patches and minor updates while remaining within the same major version, maintaining better project stability.
| "@isaacs/brace-expansion": ">=5.0.1" | |
| "@isaacs/brace-expansion": "^5.0.1" |
Summary
overridesintest-projects/expo-purchasely-test/package.jsonto force@isaacs/brace-expansionto>=5.0.1package-lock.jsonto resolve the vulnerable transitive dependencySecurity
Fixes Dependabot alert #536 —
@isaacs/brace-expansion<= 5.0.0 has an uncontrolled resource consumption vulnerability (CVE-2026-25547, High severity).Test plan
npm installsucceeds in expo test project@isaacs/brace-expansionresolves to 5.0.1 in lock file🤖 Generated with Claude Code