Time correlation and CSV output use UTC and RFC 3339#88
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates DAQ time correlation and CSV output to use UTC-based timestamps and RFC 3339 formatting, reducing ambiguity and avoiding unintended Local-time conversions.
Changes:
- Switch correlated timestamps from
chrono::Localtochrono::Utcin the correlation function and GPS-point handling. - Emit CSV “Real Time” values as RFC 3339 with millisecond precision.
- Use an RFC 3339-derived timestamp for output CSV filenames.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/daq_log_parse/table.rs |
Updates filename and CSV “Real Time” formatting to RFC 3339 (millis). |
src/daq_log_parse/correlate.rs |
Changes correlation outputs to UTC and removes Local-time conversion in GPS correlation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
irvingywang
approved these changes
Jul 3, 2026
d2f57f4 to
a92b51c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
:replaced with-to be safe for use in a file name