Skip to content

Time correlation and CSV output use UTC and RFC 3339#88

Merged
LelsersLasers merged 4 commits into
masterfrom
millan/utc_iso_8601
Jul 3, 2026
Merged

Time correlation and CSV output use UTC and RFC 3339#88
LelsersLasers merged 4 commits into
masterfrom
millan/utc_iso_8601

Conversation

@LelsersLasers

@LelsersLasers LelsersLasers commented Jul 3, 2026

Copy link
Copy Markdown
Member
  • Note: RFC 3339 is "internet-friendly" profile of ISO 8601
  • Time correlation: previously converted GPS times (which are in UTC) to Local and then converted to unix timestamps which is potentially error prone and not our intended final output
  • Output (CSV real time row): now outputs in RFC 3339 instead of a random format I hand made,
  • Output (filenaming): Uses RFC 3339 but has the : replaced with - to be safe for use in a file name

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates DAQ time correlation and CSV output to use UTC-based timestamps and RFC 3339 formatting, reducing ambiguity and avoiding unintended Local-time conversions.

Changes:

  • Switch correlated timestamps from chrono::Local to chrono::Utc in the correlation function and GPS-point handling.
  • Emit CSV “Real Time” values as RFC 3339 with millisecond precision.
  • Use an RFC 3339-derived timestamp for output CSV filenames.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/daq_log_parse/table.rs Updates filename and CSV “Real Time” formatting to RFC 3339 (millis).
src/daq_log_parse/correlate.rs Changes correlation outputs to UTC and removes Local-time conversion in GPS correlation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/daq_log_parse/correlate.rs
Comment thread src/daq_log_parse/table.rs
@LelsersLasers LelsersLasers marked this pull request as ready for review July 3, 2026 06:29
@LelsersLasers LelsersLasers requested a review from irvingywang July 3, 2026 06:29
@LelsersLasers LelsersLasers force-pushed the millan/utc_iso_8601 branch from d2f57f4 to a92b51c Compare July 3, 2026 21:01
@LelsersLasers LelsersLasers merged commit 746b9ca into master Jul 3, 2026
1 check passed
@LelsersLasers LelsersLasers deleted the millan/utc_iso_8601 branch July 3, 2026 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants