Skip to content

Use layout_compare() for AudioLayout.__eq__()#2236

Merged
WyattBlue merged 1 commit into
mainfrom
patch
Apr 18, 2026
Merged

Use layout_compare() for AudioLayout.__eq__()#2236
WyattBlue merged 1 commit into
mainfrom
patch

Conversation

@WyattBlue
Copy link
Copy Markdown
Member

And use AVCodecContext.frame_num instead of keeping track ourselves.

And use AVCodecContext.frame_num instead of keeping track ourselves.
@WyattBlue WyattBlue merged commit da9ce59 into main Apr 18, 2026
7 checks passed
@WyattBlue WyattBlue deleted the patch branch April 18, 2026 15:55
@Dobatymo
Copy link
Copy Markdown

@WyattBlue Hi! How can this be part of a patch release if it changes the public api by removing encoded_frame_count? My code is relying on that. How could I replace it? It would be nice if the docs could contain a note about this and how to adjust to it.

@WyattBlue
Copy link
Copy Markdown
Member Author

If some property is not exercised in the test suite, it's not part of the public api. This api wasn't documented either, it was just internal plumbing that was made read-only instead of private for some reason.

If your code does rely on this, just use v16.1.0. Consider this change a post release for v17.

@Dobatymo
Copy link
Copy Markdown

@WyattBlue Thank you for your response. I assumed it was public since it was documented here https://pyav.basswood-io.com/docs/16.1/api/video.html#av.video.codeccontext.VideoCodecContext.encoded_frame_count

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants