refactor(hygiene): crlf check splits severity — scripts vs cosmetic .py (#98)#99
Open
Jammy2211 wants to merge 1 commit into
Open
refactor(hygiene): crlf check splits severity — scripts vs cosmetic .py (#98)#99Jammy2211 wants to merge 1 commit into
Jammy2211 wants to merge 1 commit into
Conversation
…vs cosmetic .py (#98) The crlf mode lumped all .py and headlined 683 "debris", but the real functional risk is executable scripts (.sh + shebang-755 .py) where a CRLF shebang (#!/bin/bash\r) breaks execution on Linux/HPC. Library .py CRLF is cosmetic (Python universal newlines). Now the ranked count is the executable-script CRLF (LIVE: 6 — PyAutoConf 4, PyAutoFit 1, PyAutoLens 1) with library .py CRLF (710) reported separately as cosmetic ("leave, or '* text=auto' going forward"). Stops the check crying wolf on 710 harmless files; the default ranking self-corrects (recommends tidy 43 over crlf 6). AGENTS.md row + usage comment + /hygiene veneer updated. Follow-up (separate task): normalise the 6 scripts + add .gitattributes eol=lf guards across repos — the real, right-sized HPC fix. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Tw3EwV55k6VzxorYng3Kfn
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #98. The
crlfmode lumped all .py and headlined 683 'debris', but the real functional risk is executable scripts (.sh+ shebang-755.py) — a CRLF shebang breaks on Linux/HPC. Library.pyCRLF is cosmetic (Python universal newlines).Now the ranked count is executable-script CRLF (live: 6 — PyAutoConf 4, PyAutoFit 1, PyAutoLens 1) with library
.pyCRLF (710) reported separately as cosmetic ("leave, or '* text=auto' going forward"). Stops crying wolf; the default ranking self-corrects (recommends tidy 43 over crlf 6). Conductor-only; AGENTS.md row + usage + veneer updated. Tests 42 pass, review CLEAN.Follow-up (separate task): normalise the 6 scripts + add
.gitattributes eol=lfguards — the right-sized HPC fix.🤖 Generated with Claude Code
https://claude.ai/code/session_01Tw3EwV55k6VzxorYng3Kfn