fix: ensure aggregator helper results include datasets#221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the results aggregator release failures by making the shared quick-fit result reusable only when it contains the
image/dataset.fitsartifact required byImagingAgg. Stale or incompatibleoutput/results_foldercontents are regenerated, and aggregator scripts now pass the test-mode-awareresults_pathintoAggregator.from_directory.Scripts Changed
scripts/guides/results/_quick_fit.py— validates reusable helper output by checking for**/image/dataset.fits; removes incompatible helper output before regenerating.scripts/guides/results/aggregator/data_fitting.py— checks for a valid helper dataset and scrapesresults_path.scripts/guides/results/aggregator/models.py— checks for a valid helper dataset and scrapesresults_path.scripts/guides/results/aggregator/queries.py— uses the same valid-helper guard andresults_pathscrape directory.scripts/guides/results/aggregator/samples_via_aggregator.py— uses the same valid-helper guard andresults_pathscrape directory.scripts/guides/results/aggregator/galaxies_fits.py— uses the valid-helper guard before resuming the helper fit.scripts/guides/results/aggregator/samples.py— uses the valid-helper guard before resuming the helper fit.Test Plan
scripts/guides/results/aggregator/data_fitting.pypasses with the PyAutoBuild repro environment.scripts/guides/results/aggregator/models.pypasses with the PyAutoBuild repro environment.python ../PyAutoBuild/autobuild/run_python.py autolens scripts/guides/results/aggregator --report-dir /tmp/pyautobuild-autolens-results-aggregatorpasses all aggregator scripts.