RFC 7386 JSON Merge Patch serialization with compact format#885
Open
rickwierenga wants to merge 4 commits intomainfrom
Open
RFC 7386 JSON Merge Patch serialization with compact format#885rickwierenga wants to merge 4 commits intomainfrom
rickwierenga wants to merge 4 commits intomainfrom
Conversation
Add apply_merge_patch(), create_merge_patch(), and compact() to the serializer. compact() strips fields matching constructor defaults from serialized resource trees, producing smaller JSON without losing information. Resource.save() now emits compact format. All deserialize() methods tolerate missing optional fields so both old full-format and new compact-format JSON load correctly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
Author
|
as suggested by @Koeng101 in https://discuss.pylabrobot.org/t/json-merge-vs-json-patch/442 |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove deserialize methods that just mirror the constructor signature (Rotation, PlateAdapter, Serial, Socket, HamiltonTip, Barcode, CytomatRack, HeraeusCytomatBackend, SCILABackend, PumpCalibration). The generic deserializer or MachineBackend.deserialize handles these. Use deserialize() instead of Rotation.deserialize() in remaining methods. Fix MachineBackend.deserialize referencing data["type"] after popping it. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apply_merge_patch(),create_merge_patch(), andcompact()toserializer.pyimplementing RFC 7386 JSON Merge Patchcompact()strips fields matching constructor defaults from serialized resource trees, producing smaller JSONResource.save()now emits compact format automaticallydeserialize()methods (12 files) updated to tolerate missing optional fields, so both old full-format and new compact-format JSON load correctlydeserialize()in the core serializer now fills missing params from__init__defaults before calling constructorsTest plan
serializer_tests.pycoveringapply_merge_patch,create_merge_patch,compact, and round-trip deserializationResource.save()→Resource.load_from_json_file()round-trip🤖 Generated with Claude Code