Merged
Conversation
ZelenyMartin
requested changes
Apr 6, 2025
Comment on lines
+20
to
+23
| if s == '': | ||
| return True | ||
| else: | ||
| return False |
Contributor
There was a problem hiding this comment.
Je tam opakující se kód. Ta úloha redukování závorek by se dala řešit funkcí.
Dále se nabízí zkrácení:
Suggested change
| if s == '': | |
| return True | |
| else: | |
| return False | |
| return s == '' |
popř. return not s, ale to možná není tak čitelné.
Contributor
Author
There was a problem hiding this comment.
Ad opakující se kód - původně jsem tam funkci měla, ale to bych si pak musela přepsat test file, aby načítal i tu mou další funkci, ne?
Contributor
There was a problem hiding this comment.
Ne, test testuje funkci valid_parentheses. Pokud tato funkce volá jinou svou pomocnou funkci, tak to už je testu jedno.
JanaDrazkova
force-pushed
the
jd-33-valid-parentheses
branch
from
90c17e1 to
4f3061a
Compare
ZelenyMartin
requested changes
Apr 6, 2025
Contributor
ZelenyMartin
left a comment
ZelenyMartin
left a comment
There was a problem hiding this comment.
Nějaká další možnost zkrácení.
JanaDrazkova
force-pushed
the
jd-33-valid-parentheses
branch
from
4f3061a to
79b9282
Compare
ZelenyMartin
approved these changes
Apr 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.