fix: 📝 Add missing docs to .respond methods#3061
fix: 📝 Add missing docs to .respond methods#3061Paillat-dev merged 19 commits intoPycord-Development:masterfrom
.respond methods#3061Conversation
|
Thanks for opening this pull request! This pull request can be checked-out with: git fetch origin pull/3061/head:pr-3061
git checkout pr-3061This pull request can be installed with: pip install git+https://github.com/Pycord-Development/pycord@refs/pull/3061/head |
.respond methods
|
In case I forgot any, please tell me |
|
DA344 said I could also flesh out the method signatures of both methods to actually list and typehint the possible (kw)args for both functions, so, if you want that, just say so. |
|
I think it'd be better if the arguments were explicitly type hinted. |
|
I agree with doru |
|
This removes the |
|
I'd prefer this to be in 2.7.1 instead of 2.8 as in it's current form, it only really consists of adding missing documentation, even though that had to involve a minor code change (which doesn't cause any user code to break) |
Paillat-dev
left a comment
There was a problem hiding this comment.
code lgtm; test; thanks typing is nice :)
58f4b3e
into
Pycord-Development:master
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Paillat <paillat@pycord.dev>
Summary
Previously, the possible parameters for both
Interaction.respondandApplicationContext.respond(which copied its docs) weren't documented, this is now the caseInformation
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.