-
-
Notifications
You must be signed in to change notification settings - Fork 484
fix: 🐛 Primary guild update not firing on_user_update
#3077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 🐛 Primary guild update not firing on_user_update
#3077
Conversation
|
Thanks for opening this pull request! This pull request can be checked-out with: git fetch origin pull/3077/head:pr-3077
git checkout pr-3077This pull request can be installed with: pip install git+https://github.com/Pycord-Development/pycord@refs/pull/3077/head |
on_user_updateon_user_update
Co-authored-by: Paillat <jeremiecotti@ik.me> Signed-off-by: ToothyDev <55001472+ToothyDev@users.noreply.github.com>
Lulalaby
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That should work for now
Paillat-dev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after.primary_guild is not a PrimaryGuild object in my testing but rather just a dictionary
|
Getting the event twice: |
Paillat-dev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, works. Mostly nitpick.
Co-authored-by: Paillat-dev <me@paillat.dev>
Paillat-dev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm; tested; nice pr :)
Co-authored-by: Paillat-dev <me@paillat.dev>
Co-authored-by: Paillat-dev <me@paillat.dev>
Paillat-dev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm; tested; nice pr, thank you !
Lulalaby
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
W
Summary
Previously, an update to a user's primary guild would not fire the
on_user_updateevent. This is now the case. The underlying dict for users was also updated with the missingprimary_guildkeyInformation
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.