You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@waylan I am requesting this gets reverted. This was done with only a little testing, and once more testing is done, it is revealed this does not fully work. For instance, this works:
[`Text` and `Test`]
[`Text` and `Test`]: http://example.com
But this doesn't:
Start [`Text` and `Test`] End
[`Text` and `Test`]: http://example.com
There are some incorrect assumptions being made in the original commit that do not hold up.
To be clear, an assumption was made in the code change that assumes the Backticks processor will get the reference, enclosed with [] and will be able to reject it. But this only works in the very simple case where [`Text`] is the only text. As soon as you add any content before or after the reference, the logic no longer works. While the provided tests do work, in the real world, references will be embedded in paragraphs, and this will not actually solve the issue for most people.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 07dfa4e.
This does not fully work as advertised.