Skip to content

fix: Update device startup connection behavior #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
allenporter wants to merge 3 commits into
base: main
Choose a base branch
from
+863 −1
Draft

fix: Update device startup connection behavior #708

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
620e36b
chore: Add an end to end device manager test
allenporter Dec 23, 2025
54964d7
chore: Add end to end tests of the device cache
allenporter Dec 24, 2025
8849074
fix: Update device startup connection behavior
allenporter Dec 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,10 @@ repos:
rev: v2.2.6
hooks:
- id: codespell
exclude: >
(?x)^(
.*\.ambr
)$
- repo: https://github.com/charliermarsh/ruff-pre-commit
rev: v0.13.2
hooks:
Expand Down
4 changes: 3 additions & 1 deletion roborock/devices/device.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,9 @@
MIN_BACKOFF_INTERVAL = datetime.timedelta(seconds=10)
MAX_BACKOFF_INTERVAL = datetime.timedelta(minutes=30)
BACKOFF_MULTIPLIER = 1.5
START_ATTEMPT_TIMEOUT = datetime.timedelta(seconds=5)
# Give time for the NETWORK_INFO fetch and V1 hello attempt
# and potential fallback to L01.
START_ATTEMPT_TIMEOUT = datetime.timedelta(seconds=15)


DeviceReadyCallback = Callable[["RoborockDevice"], None]
Expand Down
1 change: 1 addition & 0 deletions tests/e2e/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,5 @@
"tests.fixtures.local_async_fixtures",
"tests.fixtures.pahomqtt_fixtures",
"tests.fixtures.aiomqtt_fixtures",
"tests.fixtures.web_api_fixtures",
]
Loading