Skip to content

Fixed broken links to Trenchbroom's Setup Guide#22

Open
mynameiswhm wants to merge 1 commit intoQodotPlugin:masterfrom
mynameiswhm:patch-1
Open

Fixed broken links to Trenchbroom's Setup Guide#22
mynameiswhm wants to merge 1 commit intoQodotPlugin:masterfrom
mynameiswhm:patch-1

Conversation

@mynameiswhm
Copy link

I've fixed two broken links to setup guide which were using domain name without protocol (resulting in invalid link in the final rendered page: https://qodotplugin.github.io/docs/beginner's-guide-to-qodot/qodotplugin.github.io/docs/beginner's-guide-to-qodot/trenchbroom-setup.html). There's also one working hardcoded link to beginner's guide.

I've changed those links to relative markdown files (which should be converted by markdown renderer, just like in other parts of the docs).

I've fixed two broken links to setup guide which were using domain name without protocol (resulting in invalid link in the final rendered page: `https://qodotplugin.github.io/docs/beginner's-guide-to-qodot/qodotplugin.github.io/docs/beginner's-guide-to-qodot/trenchbroom-setup.html`). There's also one working hardcoded link to beginner's guide.

I've changed those links to relative markdown files (which should be converted by markdown renderer, just like in other parts of the docs).
@mynameiswhm
Copy link
Author

There's also #17 which fixes the same problem, but I think using relative markdown links and relying on documentation renderer to use them is a preferred way, rather than hardcoding public URL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant