Fixed broken links to Trenchbroom's Setup Guide#22
Open
mynameiswhm wants to merge 1 commit intoQodotPlugin:masterfrom
Open
Fixed broken links to Trenchbroom's Setup Guide#22mynameiswhm wants to merge 1 commit intoQodotPlugin:masterfrom
mynameiswhm wants to merge 1 commit intoQodotPlugin:masterfrom
Conversation
I've fixed two broken links to setup guide which were using domain name without protocol (resulting in invalid link in the final rendered page: `https://qodotplugin.github.io/docs/beginner's-guide-to-qodot/qodotplugin.github.io/docs/beginner's-guide-to-qodot/trenchbroom-setup.html`). There's also one working hardcoded link to beginner's guide. I've changed those links to relative markdown files (which should be converted by markdown renderer, just like in other parts of the docs).
Author
|
There's also #17 which fixes the same problem, but I think using relative markdown links and relying on documentation renderer to use them is a preferred way, rather than hardcoding public URL. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've fixed two broken links to setup guide which were using domain name without protocol (resulting in invalid link in the final rendered page:
https://qodotplugin.github.io/docs/beginner's-guide-to-qodot/qodotplugin.github.io/docs/beginner's-guide-to-qodot/trenchbroom-setup.html). There's also one working hardcoded link to beginner's guide.I've changed those links to relative markdown files (which should be converted by markdown renderer, just like in other parts of the docs).