Skip to content

feat(glossary): add French (fr) translation glossary#68

Open
mmcky wants to merge 1 commit into
mainfrom
feat/glossary-fr
Open

feat(glossary): add French (fr) translation glossary#68
mmcky wants to merge 1 commit into
mainfrom
feat/glossary-fr

Conversation

@mmcky

@mmcky mmcky commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Adds a French built-in glossary (glossary/fr.json, 357 terms), mirroring the English term set and context fields of the existing zh-cn / fa glossaries so coverage is identical across languages.

What's included

  • glossary/fr.json — 357 terms (economics, macro/micro, finance, linear algebra, probability/statistics, time series, network science, economist & mathematician names).
  • dist-action/glossary/fr.json — the bundled copy produced by npm run build, so the action loads it automatically when target-language: fr (the CI dist-action freshness guard passes).
  • Docs updated: French row in docs/user/glossary.md and a "Current Glossaries" entry in glossary/README.md.

Conventions followed

  • Same English keys + contexts as the other glossaries (verified programmatically — identical order, no missing/extra terms).
  • Abbreviations expand to the full French term with the abbreviation in parentheses, e.g. GDP → "Produit intérieur brut (PIB)", OLS → "Moindres carrés ordinaires (MCO)".
  • Personal names keep Latin script, with French diacritics/exonyms where standard: Léon Walras, Gérard Debreu, Pythagore.

⚠️ Review note

This is an initial draft produced for native-speaker review (per the glossary quality guidelines). It is marked 🟡 Draft in glossary/README.md. A French-speaking economist should confirm terminology choices before it's promoted to ✅ Complete — particularly a few judgment calls: Apurement du marché (market clearing), Théorème folk, Stratégie de la gâchette (grim trigger), Affermage de l'impôt (tax farming).

🤖 Generated with Claude Code

Adds glossary/fr.json with 357 terms mirroring the English term set and
contexts of the existing zh-cn / fa glossaries. Bundled copy added under
dist-action/glossary/fr.json so the action loads it automatically when
target-language is `fr`.

- Economic, mathematical, statistical and finance terminology translated
  to standard French.
- Abbreviations expand to the full French term with the abbreviation in
  parentheses (e.g. GDP -> "Produit intérieur brut (PIB)").
- Personal names keep Latin script with French diacritics/exonyms where
  standard (Léon Walras, Gérard Debreu, Pythagore).

Marked as a draft pending native-speaker review in glossary/README.md and
docs/user/glossary.md.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings June 9, 2026 07:59

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a French (fr) built-in glossary intended to provide the same term coverage as existing built-in glossaries, and updates user/contributor documentation accordingly.

Changes:

  • Add glossary/fr.json (357 terms) and its bundled copy at dist-action/glossary/fr.json.
  • Update glossary documentation to list French as an available (draft) glossary.
  • Refresh glossary README metadata/date.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
glossary/README.md Documents fr.json as a current glossary and adds a French “Draft” section (but currently overstates availability given language validation).
glossary/fr.json Adds the French glossary term set (English → French) with context fields.
docs/user/glossary.md Adds French to the built-in glossary table and notes it is a draft.
dist-action/glossary/fr.json Adds the bundled French glossary copy for the distributed action artifact.

Comment thread glossary/README.md
Comment on lines 10 to 16
glossary/
├── README.md # This file
├── zh-cn.json # Simplified Chinese glossary
├── fa.json # Persian/Farsi glossary
├── fr.json # French glossary
├── ja.json # Japanese glossary (future)
└── es.json # Spanish glossary (future)
Comment thread docs/user/glossary.md
Comment on lines +15 to +19
| French | `glossary/fr.json` | 357 | June 2026 (draft) |

Both glossaries are bundled with the action and loaded automatically when the `target-language` matches. No configuration needed.
These glossaries are bundled with the action and loaded automatically when the `target-language` matches. No configuration needed.

> The French glossary is an initial draft pending native-speaker review.
Comment thread glossary/README.md
Comment on lines 23 to 30
- `zh-cn.json` - Simplified Chinese (中文简体)
- `fa.json` - Persian/Farsi (فارسی)
- `fr.json` - French (Français)
- `zh-tw.json` - Traditional Chinese (中文繁體) - future
- `ja.json` - Japanese (日本語) - future
- `es.json` - Spanish (Español) - future
- `fr.json` - French (Français) - future

The filename **must match** the `target-language` input in the workflow configuration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants