Package bluetooth manager and movehub separately - #55
Draft
HaudinFlorence wants to merge 3 commits into
Draft
Conversation
martinRenou
reviewed
Aug 12, 2026
Comment on lines
40
to
48
| "eslint": "jlpm eslint:check --fix", | ||
| "eslint:check": "eslint . --cache --ext .ts,.tsx", | ||
| "install:extension": "jlpm build", | ||
| "lint": "jlpm stylelint && jlpm prettier && jlpm eslint", | ||
| "lint:check": "jlpm stylelint:check && jlpm prettier:check && jlpm eslint:check", | ||
| "prettier": "jlpm prettier:base --write --list-different", | ||
| "prettier:base": "prettier \"**/*{.ts,.tsx,.js,.jsx,.css,.json,.md}\"", | ||
| "prettier:check": "jlpm prettier:base --check", | ||
| "stylelint": "jlpm stylelint:check --fix", | ||
| "stylelint:check": "stylelint --cache \"style/**/*.css\"", |
Member
There was a problem hiding this comment.
Let's also use lerna for lint scripts
martinRenou
reviewed
Aug 12, 2026
Member
There was a problem hiding this comment.
Let's keep a license there, and copy it in both underlying packages
| "yjs": "^13.5.0" | ||
| "style-loader": "^3.3.1" | ||
| }, | ||
| "sideEffects": [ |
Member
There was a problem hiding this comment.
The root package.json does not need this I believe.
| "strict": false | ||
| }, | ||
| "include": ["src/**/*"], | ||
| "include": ["packages/bluetooth/src/**/*", "packages/bluetooth-extension/src/**/*"], |
Member
There was a problem hiding this comment.
This is a bit odd, we should probably have a tsconfig.json in the underlying packages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.