Improve copy implementation for adjoint handling

Project.toml

@@ -1,7 +1,7 @@
 name = "BlockTensorKit"
 uuid = "5f87ffc2-9cf1-4a46-8172-465d160bd8cd"
 authors = ["Lukas Devos <ldevos98@gmail.com> and contributors"]
-version = "0.1.6"
+version = "0.1.7"
 
 [deps]
 BlockArrays = "8e7c35d0-a365-5155-bbbb-fb81a777f24e"

src/tensors/abstractblocktensor/abstractarray.jl

@@ -197,11 +197,13 @@
     return @inbounds get(parent(t), key, default)
 end
 
-Base.copy(t::AbstractBlockTensorMap) = copy!(similar(t), t)
+function Base.copy(t::AbstractBlockTensorMap)
+    return copy!(similar(t, Base.promote_op(copy, eltype(t)), space(t)), t)
+end
 function Base.copy!(tdst::AbstractBlockTensorMap, tsrc::AbstractBlockTensorMap)
     space(tdst) == space(tsrc) || throw(SpaceMismatch("$(space(tdst)) ≠ $(space(tsrc))"))
     @inbounds for (key, value) in nonzero_pairs(tsrc)
-        tdst[key] = copy(value)
+        tdst[key] = copy!(tdst[key], value)
     end
     return tdst
 end

test/abstracttensor/blocktensor.jl

@@ -207,6 +207,16 @@ end
     @test ta ≈ tb
 end
 
+@testset "Adjoint via conversion" begin
+    t1 = rand(ComplexF64, V1 ⊗ V2 ← V4')
+    a = convert(TensorMap, t1)
+    t1adj = @constinferred adjoint(t1)
+    t1adj′ = @constinferred copy(t1adj)
+    @test !(eltype(t1adj′) <: TensorKit.AdjointTensorMap)
+    @test t1adj ≈ t1adj′
+    @test a' ≈ convert(TensorMap, t1adj)
+end
+
 # if hasfusiontensor(I)
 #     @timedtestset "Tensor functions" begin
 #         W = V1 ⊗ V2