Skip to content

retain storagetype in _ind_intersect #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lkdvos merged 2 commits into from
Jan 27, 2026
+1 −1
Merged

retain storagetype in _ind_intersect #161

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3627c22
retain storagetype in `_ind_intersect`
lkdvos Jan 26, 2026
da956f0
Merge branch 'main' into ld-trues
lkdvos Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/implementations/truncation.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ end

# when one of the ind selections is a bitvector, have to handle differently
function _ind_intersect(A::AbstractVector{Bool}, B::AbstractVector)
Copy link
Member

@Jutho Jutho Jan 27, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it useful to special case

_ind_intersect(A::AbstractVector{Bool}, B::AbstractVector{Bool}) = A .& B

?

result = falses(length(A))
result = fill!(similar(A), false)
result[B] .= @view A[B]
return result
end
Expand Down