Change QR/LQ decompositions to use positive = true by default
#170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 36 files with indirect coverage changes 🚀 New features to boost your workflow:
|
lkdvos
requested changes
Feb 4, 2026
Member
lkdvos
left a comment
lkdvos
left a comment
There was a problem hiding this comment.
Could you also add this in the ### Fixed category of the changelog?
lkdvos
force-pushed
the
lb/positive_true
branch
from
76b7393 to
4643634
Compare
lkdvos
approved these changes
Feb 4, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the default behavior of QR/LQ decompositions to
positive = true.Addresses #168.