-
Notifications
You must be signed in to change notification settings - Fork 26
Fix CTMRG contraction inconsistencies #327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leburgel
reviewed
Jan 29, 2026
leburgel
reviewed
Jan 29, 2026
leburgel
reviewed
Jan 29, 2026
Co-authored-by: Lander Burgelman <39218680+leburgel@users.noreply.github.com>
…hent/PEPSKit.jl into fix-contraction-inconsistencies
leburgel
approved these changes
Jan 29, 2026
lkdvos
approved these changes
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out in #325, there are multiple inconsistencies in the docstrings, index labels and names of the CTMRG contraction code. Here I fix the docstrings, call all projectors either
P_leftorP_rightcorresponding to left and right isometries, respectively, and relabel the indices as in and out-going consistently with the TensorKit conventions.