-
-
Notifications
You must be signed in to change notification settings - Fork 92
Migration to GitHub actions #844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
EndrII
wants to merge
31
commits into
main
Choose a base branch
from
CDCI
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
15195d4
test CDCI
EndrII dc659f3
Merge branch 'main' into CDCI
EndrII 5d08d04
download all qt
EndrII 9c1427a
disable all qt module for build and deploy
EndrII 20b6ba9
update output dir
EndrII 7dca47c
fix qt package
EndrII 7499ca3
disable tests
EndrII 74a3af2
disable docs
EndrII 9f98df0
fix syntax cmake error
EndrII b9dc960
syntax
EndrII b6caf7b
fix build
EndrII 7ea042c
try to fix deploy qifw
EndrII f8e9518
fix path
EndrII b503c18
fix typo
EndrII 2a1f6a1
get qifw path wrow env
EndrII e42224b
more info
EndrII 6f7d244
move to new ubuntu
EndrII c823588
force disable parallel deploy and release
EndrII 35b1aa7
disable verbose log for deploy step
EndrII 1d17590
added lxd to ubuntu builder
EndrII 6fb3c7f
disable LSD on windows
EndrII 53a355b
added snap secret
EndrII 9c2db83
fix deploy and release snap
EndrII d217bd2
fix path of QIF
EndrII a99324a
try to fix snap base name
EndrII e33ffcd
fix snap path
EndrII cd555f2
update submodules
EndrII 702b186
update window qt depends
EndrII 0ac1644
remove specific compiller name from windows build
EndrII 66238cd
added qt mingw
EndrII 1e478a5
update sumbodules and copyright
EndrII File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This block introduces a direct dependency on GitHub Actions by checking for
ENV{GITHUB_ENV}. This couples your build script to a specific CI system. For better portability and separation of concerns, consider passing the necessary information from the CI environment to CMake via command-line arguments. For example, you could define a CMake variable likeCI_EXPORT_FILEand set it in your GitHub Actions workflow:cmake -DCI_EXPORT_FILE=$GITHUB_ENV .... Then, your CMake script would check forif(CI_EXPORT_FILE). A similar pattern is used insrc/CQtDeployer/CMakeLists.txtand should also be refactored.