-
Notifications
You must be signed in to change notification settings - Fork 5
fix(plugin): preserve Qwik lazy render metadata when wrapping components #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uration Simplify the global CSS and Tailwind configuration by removing unused variables and consolidating theme-related settings. This improves maintainability and reduces redundancy in the codebase.
The host, port, and allowedHosts configurations were removed from the dev server settings to simplify the configuration and rely on Vite's default behavior. This change reduces unnecessary customization and aligns with standard Vite practices.
Text dark and light
- Add theme script for initial theme detection and application - Update global.css with theme variables and dark mode selector - Refactor ThemeToggle component to use localStorage for theme persistence - Modify vite config to handle build-specific alias configuration - Add type definitions path to package.json ``` The commit message follows the guidelines by: 1. Using "feat" type since it introduces new theme functionality 2. Including "(theme)" scope as it's clearly theme-related 3. Keeping description under 50 chars and starting with lowercase 4. Adding a body that summarizes the key changes without repeating the subject 5. Using imperative mood throughout 6. Focusing on the significant functional changes rather than every detail
- Normalize quotes from single to double quotes - Fix missing semicolons and newlines - Reorder tailwind classes consistently - Remove unused useDark hook - Update theme script to be more reliable - Apply prettier formatting across the codebase
- Remove ThemeScript component and inline theme script logic in devtools - Remove unused useDark hook from ThemeToggle - Simplify theme toggle logic by removing dark state check
…ity condition - Remove unused ThemeScript import to clean up dependencies - Fix devtools panel visibility to only show when state.isOpen.value is true
Update all double quotes to single quotes across the codebase for consistency. Added 'singleQuote: true' to prettier configuration to enforce this style. This change improves code style consistency and aligns with the project's linting rules.
- Rename theme storage key for compatibility with vite-plugin-inspect - Extract theme script logic into separate component - Remove unused imports and simplify ThemeToggle component - Replace inline script with ThemeScript component in devtools
- Add 'auto' theme option that follows system preference - Replace button with select dropdown for theme selection - Improve theme script to handle auto theme case - Fix extra space in search input styling
…pgrade rollup to 4.41.1, and update peer dependencies
…erTree component for improved performance
…ik DevTools - Updated context management in `context.ts` for better type safety. - Introduced new performance tracking interfaces and types in `globals.ts`. - Added performance monitoring capabilities in the UI, including a new `Performance` component. - Implemented data handling for performance metrics in `computePerfViewModel.ts` and `transformPerformanceData.ts`. - Enhanced the `RenderTree` component to support performance data visualization. - Updated the `package.json` for development server configuration. - Removed deprecated `HookDataStore` and related utilities to streamline codebase.
- Introduced `getDependenciesStatus` and `refreshDependencies` methods to track and manage the state of dependencies. - Enhanced `ServerFunctions` interface with new methods for dependency management. - Updated the `QwikDevtools` component to improve data loading and error handling for assets, components, routes, and Qwik packages. - Refactored dependency preloading logic to support better concurrency and error handling. - Adjusted the `QwikRouterProvider` to disable view transitions for improved stability.
…into new_feature
🦋 Changeset detectedLatest commit: 3d99707 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
gioboa
approved these changes
Dec 19, 2025
Member
gioboa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's great 👏 @JerryWu1234
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description
fix(plugin): preserve Qwik lazy render metadata when wrapping components
Checklist
pnpm change