Skip to content

Conversation

@Daemon6109
Copy link
Contributor

for some reason declare function wasnt working properly so i switched this file to define setlLuneContext like message-emitter does, and it fixes the error, bassically server-emitter would error when running a remote function since it sets the lune context there and it was an unknown global

Copilot AI review requested due to automatic review settings December 12, 2025 20:10
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a compilation issue in server-emitter.ts where the setLuneContext function declaration was not compiling correctly. The fix changes from using declare function to declare let with a fallback no-op implementation, matching the pattern already used in message-emitter.ts. This resolves an "unknown global" error that occurred when running remote functions.

Key changes:

  • Updated setLuneContext declaration from declare function to declare let with arrow function type
  • Added nullish coalescing assignment to provide a no-op fallback implementation
  • Bumped package version from 1.3.24 to 1.4.1

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/emitters/server-emitter.ts Fixed setLuneContext declaration to use declare let pattern with fallback implementation instead of declare function
package-lock.json Updated package version from 1.3.24 to 1.4.1 to reflect the fix

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@R-unic R-unic merged commit b47aec6 into R-unic:master Dec 12, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants