Conversation
Contributor
|
It should be noted that this concerns the CALIFA per-crystal energy calibration parameters. I think that this macro will be very helpful as a reference to access rtdb parameters in a minimal way. (Note that this is not quite trivial: order matters. First rtdb->getContainer, then rtdb->initContainers, then access the container contents. Any other order will result in just reading the default data instead of the data from the file.) The maintainers will probably ask you to squash the commits before merging the PR. |
Contributor
|
@jenegger please rebase and squash the commits |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added this small macro which allows to have an insight into calibration parameters. Usually they are stored as .root files and the parameter values are usually not readable for the user. This minimal macro requests the calibration parameter file (either .par or .root file) and gives as output (either on terminal or redirected on a textfile) all the calibration parameter values stored in the calibration parameter file.