-
Notifications
You must be signed in to change notification settings - Fork 2
Improve mobile view rule page responsiveness #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
R44VC0RP
wants to merge
1
commit into
main
Choose a base branch
from
cursor/improve-mobile-view-rule-page-responsiveness-3c30
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The textarea auto-resize logic has a race condition that can cause incorrect height calculations, preventing proper auto-expansion on mobile devices.
View Details
📝 Patch Details
Analysis
In the auto-resize functionality, there's a race condition where
scrollHeightis read immediately after settingheight = 'auto'. This happens in both the initial effect (lines 131-133) and the resize handler (lines 145-146). The DOM hasn't had time to reflow and recalculate dimensions, soscrollHeightmay return the old value instead of the correct expanded height.This race condition occurs because:
textarea.style.height = 'auto'triggers a DOM updatetextarea.scrollHeightis read synchronously before the browser has paintedThe fix is to use
requestAnimationFrameto ensure the DOM has updated before readingscrollHeight:This same pattern needs to be applied in both the initial useEffect (lines 131-133) and the resize handler (lines 145-146).