Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As it was before this pull request in Sky when using a cube map TRILINEAR mip mapping was used
However, on further investigation, it seems that the actual mipmap setting used was BILINEAR_NO_MIPMAP
This leads me to the idea that this was either A. changed due to a bug or B. wrong version

You see, a bug exists if you try to use this version of g3d sky's cubemap due to TRILINEAR mipmapping which results in something like this:
However, setting it to BILINEAR_NO_MIPMAP fixes this issue (this is how I learned about this.)
Though it could also be due to a wrong version since ToneMap also needed to be added.
Either way, the correct and matching solution is to change it, so thats what this PR does