Skip to content

update to match binary#2

Open
ThePlayerRolo wants to merge 1 commit intoRBLXDecomp:masterfrom
ThePlayerRolo:master
Open

update to match binary#2
ThePlayerRolo wants to merge 1 commit intoRBLXDecomp:masterfrom
ThePlayerRolo:master

Conversation

@ThePlayerRolo
Copy link
Copy Markdown

As it was before this pull request in Sky when using a cube map TRILINEAR mip mapping was used

However, on further investigation, it seems that the actual mipmap setting used was BILINEAR_NO_MIPMAP

image On every interpolate variable in this function it uses 2, which according the PDB's is BILINEAR_NO_MIPMAP image

This leads me to the idea that this was either A. changed due to a bug or B. wrong version
You see, a bug exists if you try to use this version of g3d sky's cubemap due to TRILINEAR mipmapping which results in something like this:
image

However, setting it to BILINEAR_NO_MIPMAP fixes this issue (this is how I learned about this.)

Though it could also be due to a wrong version since ToneMap also needed to be added.

Either way, the correct and matching solution is to change it, so thats what this PR does

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant