Skip to content

fix(verify-pr): add explicit Issue Type field to Step 6d sub-task creation templates #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrizzi merged 1 commit into from
Jul 10, 2026
Merged

fix(verify-pr): add explicit Issue Type field to Step 6d sub-task creation templates #245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion evals/verify-pr/evals.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,8 @@
"The report contains a Test Change Classification row with ADDITIVE — only new test files were added (tests/api/sbom_delete.rs is a new file)",
"Convention upgrade eligibility is evaluated for review comment 30002 (index suggestion) — the review classification output (review-30002.md) or the report's Style/Conventions analysis explains whether the suggestion matches a documented or demonstrated project convention",
"Review comment 30002 (index suggestion) does NOT result in a sub-task — the suggestion classification is correct (suggestive language, no directive) and no project convention in the fixture data backs an upgrade from suggestion to code change request",
"Eval Quality is N/A because no eval result reviews exist in the PR — the 3-criteria detection (author github-actions[bot], marker ## Eval Results, footer sdlc-workflow/run-evals) found no matches, so Eval Quality does not affect the Test Quality combination"
"Eval Quality is N/A because no eval result reviews exist in the PR — the 3-criteria detection (author github-actions[bot], marker ## Eval Results, footer sdlc-workflow/run-evals) found no matches, so Eval Quality does not affect the Test Quality combination",
"The sub-task creation for comment 30001 explicitly specifies Issue Type as Sub-task — the subtask-30001.md file, the report's sub-task section, or the review classification output (review-30001.md) indicates the Jira issue is created with issueTypeName Sub-task (not as a standalone Task) to ensure parent-child hierarchy with the parent task"
]
},
{
Expand Down
3 changes: 3 additions & 0 deletions plugins/sdlc-workflow/skills/verify-pr/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,6 +485,7 @@ For each code change request (including upgraded suggestions) that requires a fi
create a Jira sub-task:

jira.create_issue with:
- **Issue Type:** Sub-task
- **Parent:** the current task's Jira issue ID
- **Summary:** concise description of the required fix
- **Labels:** `["ai-generated-jira", "review-feedback"]`
Expand Down Expand Up @@ -514,6 +515,7 @@ Process `create-sub-task` actions from the Correctness sub-agent. For each actio
files, and Root cause fields:

jira.create_issue with:
- **Issue Type:** Sub-task
- **Parent:** the current task's Jira issue ID
- **Summary:** the action's Title (e.g., "Fix failing lint check: unused import in handler.rs")
- **Labels:** `["ai-generated-jira", "review-feedback"]`
Expand Down Expand Up @@ -556,6 +558,7 @@ and sub-task creation below.
3. **Create sub-task:** For each failing eval, create a Jira sub-task:

jira.create_issue with:
- **Issue Type:** Sub-task
- **Parent:** the current task's Jira issue ID
- **Summary:** "Fix <eval-id> assertion failures: <brief description of failures>"
- **Labels:** `["ai-generated-jira", "eval-failure"]`
Expand Down
Loading