So you're telemetrying me that the data from the base is wrong?#19
Open
So you're telemetrying me that the data from the base is wrong?#19
Conversation
…s all history if an error was encountered while uploading and sends the error to the front-end. Also lightly edited around parse_data to make it work more betterer (wasn't working on my machine)
Contributor
Author
|
This actually has not been tested because I do not have enough data to safely test it. However, I am opening this to get some eyes on it and make sure that I have the correct idea for this code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added guarding in data_upload.py around submit_data so that it removes all history if an error was encountered while uploading and sends the error to the front-end. Also lightly edited around parse_data to make it work more betterer (wasn't working on my machine)