[BugFix][model_ops] chunk shuffle_weights to reduce load-time memory usage#530
Open
[BugFix][model_ops] chunk shuffle_weights to reduce load-time memory usage#530
Conversation
whx-sjtu
changed the title
whx-sjtu
changed the title
Signed-off-by: whx-sjtu <xiaowang990929@gmail.com>
whx-sjtu
force-pushed
the
whx/fix-glm5-shuffle-oom
branch
from
811422e to
4e5b0b7
Compare
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
whx-sjtu
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently there exists an OOM error when running GLM5 on mi355 with TP4. The error is introduced by
shuffle_weightsafter loading the model. For MoE models the gemm weights are[num_experts, k, n]. Original version shuffle this weight once. This PR solves this problem by spliting MoE gemm weights expert by expert.Test plan
shuffle_weight(...).contiguous()path)