Open
Conversation
wuhuikx
commented
Apr 10, 2026
| OOT_IMAGE_TAG: ${{ needs.build-oot-image.outputs.oot_image_tag || needs.resolve-atom-source.outputs.prebuilt_oot_image }} | ||
| CONTAINER_RESULT_DIR: /tmp/vLLM-ATOM-benchmark-results | ||
| CONTAINER_BENCH_SERVING_DIR: /tmp/vLLM-ATOM-benchmark/bench_serving | ||
| OOT_IMAGE_TAG: ${{ needs.build-vLLM-ATOM-image.outputs.oot_image_tag || needs.resolve-atom-source.outputs.prebuilt_oot_image }} |
Contributor
Author
There was a problem hiding this comment.
how about this change?
| uses: actions/upload-artifact@v7 | ||
| with: | ||
| name: oot-benchmark-regression-report | ||
| name: vLLM-ATOM-benchmark-regression-report |
Contributor
Author
There was a problem hiding this comment.
how about this one, use vllm-atom-benchmark-regression-report ?
| - name: Initialize vLLM-ATOM image tag | ||
| run: | | ||
| echo "OOT_IMAGE_TAG=rocm/atom-dev:oot-pre-build-${GITHUB_COMMIT_SHA}" >> "$GITHUB_ENV" | ||
| echo "OOT_IMAGE_TAG=rocm/atom-dev:vLLM-ATOM-pre-build-${GITHUB_COMMIT_SHA}" >> "$GITHUB_ENV" |
Contributor
Author
There was a problem hiding this comment.
how about vllm-atom-pre-build-xxx?
Contributor
There was a problem hiding this comment.
correct, but the TAG should be changed also, OOT_IMAGE_TAG -> vLLM_ATOM_IMAGE_TAG
atom/plugin/vllm/model_wrapper.py
Outdated
| model_ref = _ATOM_MODEL_CLASSES[model_arch] | ||
| else: | ||
| raise ValueError(f"The {model_arch} is not supported by ATOM OOT backend") | ||
| raise ValueError(f"The {model_arch} is not supported by ATOM vLLM-ATOM backend") |
Contributor
There was a problem hiding this comment.
Suggested change
| raise ValueError(f"The {model_arch} is not supported by ATOM vLLM-ATOM backend") | |
| raise ValueError(f"The {model_arch} is not supported by vLLM-ATOM") |
atom/plugin/vllm/register.py
Outdated
| # return None instead of error because the flag can be used to | ||
| # run pure vllm mode without ATOM plugin | ||
| logger.info("Disable ATOM OOT plugin platforms") | ||
| logger.info("Disable ATOM vLLM-ATOM plugin platforms") |
Contributor
There was a problem hiding this comment.
Suggested change
| logger.info("Disable ATOM vLLM-ATOM plugin platforms") | |
| logger.info("Disable vLLM-ATOM plugin platform") |
Collaborator
|
consider we will have sglang also, i would prefer rename to ATOM-vLLM/ATOM-SGLANG |
Signed-off-by: zejunchen-zejun <zejun.chen@amd.com>
Signed-off-by: zejunchen-zejun <zejun.chen@amd.com>
Signed-off-by: zejunchen-zejun <zejun.chen@amd.com>
Contributor
Author
|
@zejunchen-zejun can you please help take a look again? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the word of "OOT", change name to "vLLM-ATOM".