fix(dashboard): Fix SGLang benchmark workflow and integrate into dashboard#548
Draft
zhuyuhua-v wants to merge 4 commits intomainfrom
Draft
fix(dashboard): Fix SGLang benchmark workflow and integrate into dashboard#548zhuyuhua-v wants to merge 4 commits intomainfrom
zhuyuhua-v wants to merge 4 commits intomainfrom
Conversation
Signed-off-by: zhuyuhua-v <yuhzhu@amd.com>
Signed-off-by: zhuyuhua-v <yuhzhu@amd.com>
Signed-off-by: zhuyuhua-v <yuhzhu@amd.com>
Signed-off-by: zhuyuhua-v <yuhzhu@amd.com>
e8d9255 to
1f36af3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a dedicated GitHub Actions workflow for benchmarking ATOM-accelerated SGLang (
atom-sglang-benchmark.yaml) and officially integrates its performance results into the benchmark dashboard.To avoid code duplication, it also refactors the existing vLLM Python scripts into generic plugin scripts shared by both frameworks.
SGLang Benchmark Details
workflow_dispatch).DeepSeek-R1-0528(FP8 TP8).atom-mi355-8gpu-oot-benchmark(MI355 8-GPU machines).Dashboard Integration
-30) forATOM-SGLanginindex.htmlto visually distinguish its charts fromATOMandATOM-vLLM.atom_logo_mini.pngis correctly copied to thegh-pagesbranch.Script Unification (SGLang & vLLM)
oot_benchmark_*.pyscripts toplugin_benchmark_*.pyto make them framework-agnostic.atom-sglang-benchmark.yamlandatom-vllm-oot-benchmark.yamlto reuse these unified scripts by passing specific arguments (e.g.,--titleand--default-backend).Docker Release Workflow Fix
docker-release.yaml: Previously, if a user checked bothonly_release_ootandonly_release_sglang, the workflow would fail to build either image. The logic has been updated so that if both are checked, both the OOT and SGLang images will be built and released (while still correctly skipping the native image test/push). The UI descriptions for these inputs have been updated to reflect this behavior.