perf : disable ndarray by default#74
Open
usaxena-4md wants to merge 1 commit into
Open
Conversation
Flip the default of GS_ENABLE_NDARRAY from "1" to "0" so ndarray is disabled unless explicitly enabled. Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
|
If we disable GS_ENABLE_NDARRAY, the unit test will run much slower. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Flips the default value of the
GS_ENABLE_NDARRAYenvironment variablefrom
"1"to"0", so ndarray is disabled by default unless a userexplicitly opts in by setting
GS_ENABLE_NDARRAY=1.Change
In
genesis/__init__.py,init():