Skip to content

perf : disable ndarray by default#74

Open
usaxena-4md wants to merge 1 commit into
amd-integrationfrom
perf/arbor/disable-ndarray-by-default
Open

perf : disable ndarray by default#74
usaxena-4md wants to merge 1 commit into
amd-integrationfrom
perf/arbor/disable-ndarray-by-default

Conversation

@usaxena-4md

Copy link
Copy Markdown
Collaborator

Summary

Flips the default value of the GS_ENABLE_NDARRAY environment variable
from "1" to "0", so ndarray is disabled by default unless a user
explicitly opts in by setting GS_ENABLE_NDARRAY=1.

Change

In genesis/__init__.py, init():

# before
is_ndarray_disabled = os.environ.get("GS_ENABLE_NDARRAY", "1") == "0"
# after
is_ndarray_disabled = os.environ.get("GS_ENABLE_NDARRAY", "0") == "0"

Flip the default of GS_ENABLE_NDARRAY from "1" to "0" so ndarray is
disabled unless explicitly enabled.

Co-authored-by: Cursor <cursoragent@cursor.com>
@peizhang56

Copy link
Copy Markdown
Collaborator

If we disable GS_ENABLE_NDARRAY, the unit test will run much slower.
I would not change it to 0, instead, user can use performance mode to set it 0 by env

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants