Conversation
| $hsacoVersion = $arg; | ||
| $swallowArg = 1; | ||
| } | ||
| if($arg =~ /\.rsp$/) { |
There was a problem hiding this comment.
Do you have an example response file that this patch is trying to fix? What is the error without this patch?
There was a problem hiding this comment.
The error that we see is one hip-tests, GraphTests have grown in size and the final linkage line is too big on windows.
For now we have fixed it via a hack: ROCm/hip-tests@fe9515a basically split it in two exe till we have a fix in place.
To fix this we need to enable rsp files inside hip-tests CMake (done via: ROCm/hip-tests#360 ) but before that hipcc needs to escape rsp files and add proper encoding for windows.
There was a problem hiding this comment.
Edit: we got same error for memory tests as well: ROCm/hip-tests#362
kzhuravl
left a comment
kzhuravl
left a comment
There was a problem hiding this comment.
LGTM, but please run the psdb before merging.
3 participants
File names starting with @ can not be escaped.
This is needed for really long command lines with tests on windows