Added gfx950a to pyt_mochi_inference.ubuntu dockerfile to enable fa#148
Open
vadseshu wants to merge 1 commit intoROCm:developfrom
Open
Added gfx950a to pyt_mochi_inference.ubuntu dockerfile to enable fa#148vadseshu wants to merge 1 commit intoROCm:developfrom
vadseshu wants to merge 1 commit intoROCm:developfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the AMD Ubuntu Mochi inference Dockerfile to include the MI350/MI355 GPU architecture in the ROCm arch list so flash-attention can be built/enabled on those GPUs.
Changes:
- Add
gfx950toPYTORCH_ROCM_ARCHinpyt_mochi_inference.ubuntu.amd.Dockerfile.
Comments suppressed due to low confidence (1)
docker/pyt_mochi_inference.ubuntu.amd.Dockerfile:40
PYTORCH_ROCM_ARCHis a semicolon-delimited list, but it’s later expanded unquoted in theGPU_ARCHS=$(echo ${PYTORCH_ROCM_ARCH} | ...)command and then used in an env-var assignment. Insh, the semicolons will be treated as command separators (e.g.,echo gfx950;gfx90a;...), which can break the Docker build. Quote the expansion and ensure the computedGPU_ARCHSvalue is passed/assigned in a way that preserves the semicolons (or convert the list to a delimiter that’s shell-safe before using it).
ARG PYTORCH_ROCM_ARCH=gfx950;gfx90a;gfx942;gfx1100;gfx1101;gfx1200;gfx1201
RUN git clone ${FA_REPO}
RUN cd flash-attention \
&& git submodule update --init \
&& GPU_ARCHS=$(echo ${PYTORCH_ROCM_ARCH} | sed -e 's/;gfx1[0-9]\{3\}//g') python3 setup.py bdist_wheel --dist-dir=dist \
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| ARG FA_REPO="https://github.com/Dao-AILab/flash-attention.git" | ||
| ARG PYTORCH_ROCM_ARCH=gfx90a;gfx942;gfx1100;gfx1101;gfx1200;gfx1201 | ||
| ARG PYTORCH_ROCM_ARCH=gfx950;gfx90a;gfx942;gfx1100;gfx1101;gfx1200;gfx1201 |
There was a problem hiding this comment.
The PR title mentions adding gfx950a, but the Dockerfile adds gfx950. Please confirm the intended ROCm arch string for MI350/MI355 and align either the Dockerfile value or the PR title/description to avoid confusion for downstream users.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
PR to fix the pyt_mochi_video_inference enablment on Mi350/ Mi355.
Technical Details
Updated gfx arch for Mi350 on mochi inference dockerfile
Test Plan
Test Result
Submission Checklist